-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Implement recent commits graph #29210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1e02efc
Add initial recent commits page
sahinakkaya dcbd982
Merge remote-tracking branch 'upstream/main' into commits-graph
sahinakkaya 55da039
Implement recent commits page
sahinakkaya 4310f77
Merge remote-tracking branch 'upstream/main' into recent-commits-graph
sahinakkaya 16e5260
Fix linting error
sahinakkaya 2ba7d90
Remove unnecessary imports
sahinakkaya 7114f23
Merge remote-tracking branch 'upstream/main' into recent-commits-graph
sahinakkaya 17dc1eb
Deduplicate translations
sahinakkaya de99eba
Deduplicate translations
sahinakkaya e182747
Merge remote-tracking branch 'upstream/main' into recent-commits-graph
sahinakkaya 36e8d06
Merge remote-tracking branch 'upstream/main' into recent-commits-graph
sahinakkaya 67aa2e1
Use util functions and variables for common code
sahinakkaya c2c675e
Make graph smaller
sahinakkaya f8771d5
Apply suggestions from code review
sahinakkaya bc0294d
Revert "Apply suggestions from code review"
sahinakkaya 230c313
Merge branch 'main' into recent-commits-graph
wxiaoguang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright 2023 The Gitea Authors. All rights reserved. | ||
// SPDX-License-Identifier: MIT | ||
|
||
package repo | ||
|
||
import ( | ||
"errors" | ||
"net/http" | ||
|
||
"code.gitea.io/gitea/modules/base" | ||
"code.gitea.io/gitea/modules/context" | ||
contributors_service "code.gitea.io/gitea/services/repository" | ||
) | ||
|
||
const ( | ||
tplRecentCommits base.TplName = "repo/activity" | ||
) | ||
|
||
// RecentCommits renders the page to show recent commit frequency on repository | ||
func RecentCommits(ctx *context.Context) { | ||
ctx.Data["Title"] = ctx.Tr("repo.activity.navbar.recent_commits") | ||
|
||
ctx.Data["PageIsActivity"] = true | ||
ctx.Data["PageIsRecentCommits"] = true | ||
ctx.PageData["repoLink"] = ctx.Repo.RepoLink | ||
|
||
ctx.HTML(http.StatusOK, tplRecentCommits) | ||
} | ||
|
||
// RecentCommitsData returns JSON of recent commits data | ||
func RecentCommitsData(ctx *context.Context) { | ||
if contributorStats, err := contributors_service.GetContributorStats(ctx, ctx.Cache, ctx.Repo.Repository, ctx.Repo.CommitID); err != nil { | ||
if errors.Is(err, contributors_service.ErrAwaitGeneration) { | ||
ctx.Status(http.StatusAccepted) | ||
return | ||
} | ||
ctx.ServerError("RecentCommitsData", err) | ||
} else { | ||
ctx.JSON(http.StatusOK, contributorStats["total"].Weeks) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{{if .Permission.CanRead $.UnitTypeCode}} | ||
<div id="repo-recent-commits-chart" | ||
data-locale-loading-title="{{ctx.Locale.Tr "graphs.component_loading" (ctx.Locale.Tr "graphs.recent_commits.what")}}" | ||
data-locale-loading-title-failed="{{ctx.Locale.Tr "graphs.component_loading_failed" (ctx.Locale.Tr "graphs.recent_commits.what")}}" | ||
data-locale-loading-info="{{ctx.Locale.Tr "graphs.component_loading_info"}}" | ||
data-locale-component-failed-to-load="{{ctx.Locale.Tr "graphs.component_failed_to_load"}}" | ||
> | ||
</div> | ||
{{end}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,149 @@ | ||
<script> | ||
import {SvgIcon} from '../svg.js'; | ||
import { | ||
Chart, | ||
Tooltip, | ||
BarElement, | ||
LinearScale, | ||
TimeScale, | ||
} from 'chart.js'; | ||
import {GET} from '../modules/fetch.js'; | ||
import {Bar} from 'vue-chartjs'; | ||
import { | ||
startDaysBetween, | ||
firstStartDateAfterDate, | ||
fillEmptyStartDaysWithZeroes, | ||
} from '../utils/time.js'; | ||
import {chartJsColors} from '../utils/color.js'; | ||
import {sleep} from '../utils.js'; | ||
import 'chartjs-adapter-dayjs-4/dist/chartjs-adapter-dayjs-4.esm'; | ||
|
||
const {pageData} = window.config; | ||
|
||
Chart.defaults.color = chartJsColors.text; | ||
Chart.defaults.borderColor = chartJsColors.border; | ||
|
||
Chart.register( | ||
TimeScale, | ||
LinearScale, | ||
BarElement, | ||
Tooltip, | ||
); | ||
|
||
export default { | ||
components: {Bar, SvgIcon}, | ||
props: { | ||
locale: { | ||
type: Object, | ||
required: true | ||
}, | ||
}, | ||
data: () => ({ | ||
isLoading: false, | ||
errorText: '', | ||
repoLink: pageData.repoLink || [], | ||
data: [], | ||
}), | ||
mounted() { | ||
this.fetchGraphData(); | ||
}, | ||
methods: { | ||
async fetchGraphData() { | ||
this.isLoading = true; | ||
try { | ||
let response; | ||
do { | ||
response = await GET(`${this.repoLink}/activity/recent-commits/data`); | ||
if (response.status === 202) { | ||
await sleep(1000); // wait for 1 second before retrying | ||
} | ||
} while (response.status === 202); | ||
if (response.ok) { | ||
const data = await response.json(); | ||
const start = Object.values(data)[0].week; | ||
const end = firstStartDateAfterDate(new Date()); | ||
const startDays = startDaysBetween(new Date(start), new Date(end)); | ||
this.data = fillEmptyStartDaysWithZeroes(startDays, data).slice(-52); | ||
this.errorText = ''; | ||
} else { | ||
this.errorText = response.statusText; | ||
} | ||
} catch (err) { | ||
this.errorText = err.message; | ||
} finally { | ||
this.isLoading = false; | ||
} | ||
}, | ||
|
||
toGraphData(data) { | ||
return { | ||
datasets: [ | ||
{ | ||
data: data.map((i) => ({x: i.week, y: i.commits})), | ||
label: 'Commits', | ||
backgroundColor: chartJsColors['commits'], | ||
borderWidth: 0, | ||
tension: 0.3, | ||
}, | ||
], | ||
}; | ||
}, | ||
|
||
getOptions() { | ||
return { | ||
responsive: true, | ||
maintainAspectRatio: false, | ||
animation: true, | ||
scales: { | ||
x: { | ||
type: 'time', | ||
grid: { | ||
display: false, | ||
}, | ||
time: { | ||
minUnit: 'week', | ||
}, | ||
ticks: { | ||
maxRotation: 0, | ||
maxTicksLimit: 52 | ||
}, | ||
}, | ||
y: { | ||
ticks: { | ||
maxTicksLimit: 6 | ||
}, | ||
}, | ||
}, | ||
}; | ||
}, | ||
}, | ||
}; | ||
</script> | ||
<template> | ||
<div> | ||
<div class="ui header gt-df gt-ac gt-sb"> | ||
{{ isLoading ? locale.loadingTitle : errorText ? locale.loadingTitleFailed: "Number of commits in the past year" }} | ||
</div> | ||
sahinakkaya marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<div class="gt-df ui segment main-graph"> | ||
<div v-if="isLoading || errorText !== ''" class="gt-tc gt-m-auto"> | ||
<div v-if="isLoading"> | ||
<SvgIcon name="octicon-sync" class="gt-mr-3 job-status-rotate"/> | ||
{{ locale.loadingInfo }} | ||
</div> | ||
<div v-else class="text red"> | ||
<SvgIcon name="octicon-x-circle-fill"/> | ||
{{ errorText }} | ||
</div> | ||
</div> | ||
<Bar | ||
v-memo="data" v-if="data.length !== 0" | ||
:data="toGraphData(data)" :options="getOptions()" | ||
/> | ||
</div> | ||
</div> | ||
</template> | ||
<style scoped> | ||
.main-graph { | ||
height: 250px; | ||
} | ||
wxiaoguang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import {createApp} from 'vue'; | ||
|
||
export async function initRepoRecentCommits() { | ||
const el = document.getElementById('repo-recent-commits-chart'); | ||
if (!el) return; | ||
|
||
const {default: RepoRecentCommits} = await import(/* webpackChunkName: "recent-commits-graph" */'../components/RepoRecentCommits.vue'); | ||
try { | ||
const View = createApp(RepoRecentCommits, { | ||
locale: { | ||
loadingTitle: el.getAttribute('data-locale-loading-title'), | ||
loadingTitleFailed: el.getAttribute('data-locale-loading-title-failed'), | ||
loadingInfo: el.getAttribute('data-locale-loading-info'), | ||
} | ||
}); | ||
View.mount(el); | ||
} catch (err) { | ||
console.error('RepoRecentCommits failed to load', err); | ||
el.textContent = el.getAttribute('data-locale-component-failed-to-load'); | ||
sahinakkaya marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.