Skip to content

Improve clickable area in repo action view page #26115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 15, 2023
Merged

Improve clickable area in repo action view page #26115

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ee97d99
improve
yp05327 Jul 25, 2023
7b9af90
Merge branch 'main' into improve-job-select
yp05327 Aug 4, 2023
deaf22b
improve
yp05327 Aug 4, 2023
e9df407
remove .job-brief-item-left:hover
yp05327 Aug 8, 2023
72300d0
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
b8e91aa
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
4cfc7aa
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
63039cd
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
5cf339c
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
cb73493
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
8d8afb9
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
4a4d7a4
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
ec14b51
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
70cd7f3
Merge branch 'main' into improve-job-select
GiteaBot Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions web_src/js/components/RepoActionView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@
<div class="action-view-left">
<div class="job-group-section">
<div class="job-brief-list">
<div class="job-brief-item" :class="parseInt(jobIndex) === index ? 'selected' : ''" v-for="(job, index) in run.jobs" :key="job.id" @mouseenter="onHoverRerunIndex = job.id" @mouseleave="onHoverRerunIndex = -1">
<a class="job-brief-link" :href="run.link+'/jobs/'+index">
<a class="job-brief-item" :href="run.link+'/jobs/'+index" :class="parseInt(jobIndex) === index ? 'selected' : ''" v-for="(job, index) in run.jobs" :key="job.id" @mouseenter="onHoverRerunIndex = job.id" @mouseleave="onHoverRerunIndex = -1">
<div class="job-brief-link">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div inside a is not allowed, if I'm not mistaken.

Copy link
Member

@silverwind silverwind Jul 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine. This was forbidden in HTML 4, but has since been relaxed with HTML 5. We already do it in a number of places like migration cards.

<ActionRunStatus :locale-status="locale.status[job.status]" :status="job.status"/>
<span class="job-brief-name gt-mx-3 gt-ellipsis">{{ job.name }}</span>
</a>
</div>
<span class="job-brief-info">
<SvgIcon name="octicon-sync" role="button" :data-tooltip-content="locale.rerun" class="job-brief-rerun gt-mx-3" @click="rerunJob(index)" v-if="job.canRerun && onHoverRerunIndex === job.id"/>
<span class="step-summary-duration">{{ job.duration }}</span>
</span>
</div>
</a>
</div>
</div>
<div class="job-artifacts" v-if="artifacts.length > 0">
Expand Down Expand Up @@ -585,6 +585,7 @@ export function initRepositoryActionView() {
flex-wrap: nowrap;
justify-content: space-between;
align-items: center;
color: var(--color-text);
}

.job-brief-item:hover {
Expand Down Expand Up @@ -623,7 +624,6 @@ export function initRepositoryActionView() {
.job-brief-item .job-brief-link .job-brief-name {
display: block;
width: 70%;
color: var(--color-text);
}

.job-brief-item .job-brief-link:hover {
Expand Down