Skip to content

Always use user/branch for source branch display in PR #23779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Always use user/branch for source branch display in PR #23779

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 29, 2023 •
edited
Loading

Before:

image

After:
image

Fixes: #20408

@silverwind silverwind changed the title Always use user/repo for source branch display in PR Always use user/branch for source branch display in PR Mar 29, 2023
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Mar 29, 2023
yardenshoham
yardenshoham suggested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe : instead of / to match GitHub?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2023
@silverwind
Copy link
Member Author

Maybe : instead of / to match GitHub?

As mentioned here, I believe / is superior because that's what git cli accepts. : is not useful on git cli. Gitlab also uses the / separator, so I believe the : is a GitHub-specific quirk.

@silverwind
Copy link
Member Author

silverwind commented Mar 29, 2023 •
edited
Loading

There is more discussion in #20408. Current format is useful for gitea UI, the format in this PR is useful with git cli. I'm wondering if we should maybe support both cases with a second copy button specific for git cli maybe, or just prefer git cli, which matches gitlab.

@lunny
Copy link
Member

lunny commented Mar 29, 2023

There is more discussion in #20408. Current format is useful for gitea UI, the format in this PR is useful with git cli. I'm wondering if we should maybe support both cases with a second copy button specific for git cli maybe, or just prefer git cli, which matches gitlab.

But we already have command line hint although it's at the end of the page.

@silverwind
Copy link
Member Author

But we already have command line hint although it's at the end of the page.

Those instructions do not match my workflow unfortunately.

@silverwind
Copy link
Member Author

Think we'll try another approach by improving the PR instructions.

@silverwind silverwind closed this Apr 1, 2023
@silverwind silverwind deleted the sourcebranch branch April 1, 2023 06:07
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yardenshoham yardenshoham yardenshoham requested changes

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source branch reference should probably be user/repo
4 participants
@silverwind @lunny @yardenshoham @GiteaBot