cmd: restore-repo --units is repeated #19935
Conversation
It is not a coma separated value. Add tests and fix the documentation.
GiteaBot
added
the
lgtm/need 1
GiteaBot
added
lgtm/done
| "pull_requests", | ||
| "comments", | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this default value is not ideal for the server code.
The default value should be 0-length slice to indicate all units (there may be more in the future).
update: if it guarantees that the units always contains the units to be restored, the support for len(units) == 0 should be deleted to make the logic consistent.
There was a problem hiding this comment.
I think it's a good idea to reduce the possibility to forget the places when we support more units.
| Usage: `Which items will be restored, one or more units should be separated as comma. | ||
| wiki, issues, labels, releases, release_assets, milestones, pull_requests, comments are allowed. Empty means all units.`, | ||
| Value: &defaultUnits, | ||
| Usage: "Which items will be restored, can be repeated", |
There was a problem hiding this comment.
| Usage: "Which items will be restored, can be repeated", | |
| Usage: "Which items (wiki, issues, labels, releases, release_assets, milestones, pull_requests, comments) will be restored, can be repeated. Not providing this flag means all units.", |
|
Since it works, no blocker from my side. Just put my thoughts here. |
|
This pull request is closed as requested by the author who will not be able to answer further questions here because they do not have a GitHub account. |
It is not a coma separated value. Add tests and fix the documentation.
This PR originates from @dachary of the forgefriends project. Please see here for origin.