Feeds: render markdown to html #19058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
Mar 12, 2022
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Mar 12, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #19058 +/- ##
==========================================
- Coverage 46.62% 46.54% -0.08%
==========================================
Files 854 854
Lines 122587 122935 +348
==========================================
+ Hits 57153 57222 +69
- Misses 58537 58791 +254
- Partials 6897 6922 +25
Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 14, 2022
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix documentation and go-gitea#19065 (go-gitea#19067) RSS/Atom support for Repos (go-gitea#19055) [skip ci] Updated licenses and gitignores Feeds: render markdown to html (go-gitea#19058) [skip ci] Updated translations via Crowdin
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* feeds: render markdown to html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/PR/Comment/Review content was previously emitted as raw markdown.
HTML content is supported by all atom/rss clients (and also the assumed default in Gitea's renderer).
before:
after:
As seen in the screenshots, Thunderbird doesn't render html in the title. Is anyone aware of RSS clients that do? If not, I'd remove HTML from the title elements in this PR as well..
edit: looks like Nextcloud News does render HTML in the title, though the link is not clickable, as the title is entirely an
<a>element