-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Allow render HTML with css/js external links #19017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
581e415
Allow render HTML with css/js external links
lunny c727f99
Fix bug because of filename escape chars
lunny b04430d
Fix lint
lunny d980996
Update docs about new configuration item
lunny 6e012d9
Fix bug of render HTML in sub directory
lunny 7a4a58f
Add CSP head for displaying iframe in rendering file
lunny c3bfd5b
Fix test
lunny 7ec5ac6
merge
lunny 2006683
Apply suggestions from code review
lunny 400308e
Some improvements
lunny 9460386
Merge branch 'main' into lunny/render_iframe
lunny 2c21f6f
merge
lunny feb290a
some improvement
lunny 2987a7a
Merge branch 'main' into lunny/render_iframe
lunny 4520ea9
revert change in SanitizerDisabled of external renderer
lunny a69ec31
Add sandbox for iframe and support allow-scripts and allow-same-origin
lunny 05bc9b2
Merge branch 'main' into lunny/render_iframe
lunny 7d0e74e
refactor
wxiaoguang 069b236
Merge pull request #23 from wxiaoguang/lunny/render_iframe
lunny a929430
fix
wxiaoguang 806e647
fix lint
wxiaoguang 5a2416e
fine tune
wxiaoguang eb52c83
Merge branch 'main' into lunny/render_iframe
wxiaoguang d9679ce
use single option RENDER_CONTENT_MODE, use sandbox=allow-scripts
wxiaoguang a1cac2a
fine tune CSP
wxiaoguang cc18ebf
Apply suggestions from code review
lunny 65443b2
Merge branch 'main' into lunny/render_iframe
wxiaoguang 6c81597
Merge branch 'main' into lunny/render_iframe
lunny 631fea3
Merge branch 'main' into lunny/render_iframe
lunny 169362d
Merge branch 'main' into lunny/render_iframe
wxiaoguang c7df5bf
Merge branch 'main' into lunny/render_iframe
lunny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -230,7 +230,7 @@ John Doe [email protected] This,note,had,a,lot,of,commas,to,test,delimiters`, | |
} | ||
|
||
for n, c := range cases { | ||
delimiter := determineDelimiter(&markup.RenderContext{Filename: c.filename}, []byte(decodeSlashes(t, c.csv))) | ||
delimiter := determineDelimiter(&markup.RenderContext{RelativePath: c.filename}, []byte(decodeSlashes(t, c.csv))) | ||
assert.EqualValues(t, c.expectedDelimiter, delimiter, "case %d: delimiter should be equal, expected '%c' got '%c'", n, c.expectedDelimiter, delimiter) | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.