Fix continuance tests #18027
Merged
Fix continuance tests #18027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gusted
commented
Dec 19, 2021
Gusted
commented
- Fix errors on tests that aren't first-run.
- Resolves Integration tests fail if LANG is not "" #18021
- Fix errors on tests that aren't first-run. - Resolves go-gitea#18021
zeripath
approved these changes
Dec 19, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
added
type/testing
and removed
lgtm/need 1
|
Is it better to prepare a clean environment every-time than cleaning up? If we try to clean the modified test data, there may be still a chance that the test data can not be recovered (eg: panic), and in future more and more tests would have to do such cleaning up (and some developers may forget to do it). |
GiteaBot
added
the
lgtm/need 1
We can run the clean command beforehand, but I personally don't have a good feeling by doing that - I don't have any objections either. |
wxiaoguang
approved these changes
Dec 21, 2021
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.