Skip to content

migration: github: if rate limit is not enabled, ignore it #15490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2021
Merged

migration: github: if rate limit is not enabled, ignore it #15490

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
657994b
migration: github: if rate limit is not enabled, ignore it
6543 Apr 15, 2021
1004612
use nil
6543 Apr 15, 2021
dc4ba4a
log nil response
6543 Apr 15, 2021
12e26f2
next
6543 Apr 15, 2021
ee9cb51
Merge branch 'master' into migration_github-e_ignore-ratelimit-on-404
6543 Apr 15, 2021
add9c1b
Merge branch 'master' into migration_github-e_ignore-ratelimit-on-404
zeripath Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/migrations/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,15 @@ func (g *GithubDownloaderV3) sleep() {

// RefreshRate update the current rate (doesn't count in rate limit)
func (g *GithubDownloaderV3) RefreshRate() error {
rates, _, err := g.client.RateLimits(g.ctx)
rates, resp, err := g.client.RateLimits(g.ctx)
if err != nil {
// if rate limit is not enabled, ignore it
if resp != nil && resp.StatusCode == http.StatusNotFound {
g.rate = nil
return nil
} else {
log.Error("TEST: RefreshRate resp status is nil!")
}
return err
}

Expand Down