Fix bug preventing transfer to private organization #12497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code assessing whether a private organization was visible to a user before allowing transfer was incorrect due to testing membership the wrong way round This PR fixes this issue and renames the function performing the test to be clearer. Further looking at the API for transfer repository - no testing was performed to ensure that the acting user could actually see the new owning organization. Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
- Coverage 43.73% 43.73% -0.01%
==========================================
Files 631 631
Lines 69873 69877 +4
==========================================
+ Hits 30561 30562 +1
- Misses 34352 34355 +3
Partials 4960 4960
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Aug 16, 2020
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Aug 16, 2020
GiteaBot
added
lgtm/done
techknowlogick
pushed a commit
to techknowlogick/gitea
that referenced
this pull request
Aug 16, 2020
* Fix bug preventing transfer to private organization The code assessing whether a private organization was visible to a user before allowing transfer was incorrect due to testing membership the wrong way round This PR fixes this issue and renames the function performing the test to be clearer. Further looking at the API for transfer repository - no testing was performed to ensure that the acting user could actually see the new owning organization. Signed-off-by: Andrew Thornton <[email protected]> * change IsUserPartOfOrg everywhere
techknowlogick
added
the
backport/done
lafriks
pushed a commit
that referenced
this pull request
Aug 17, 2020
* Fix bug preventing transfer to private organization The code assessing whether a private organization was visible to a user before allowing transfer was incorrect due to testing membership the wrong way round This PR fixes this issue and renames the function performing the test to be clearer. Further looking at the API for transfer repository - no testing was performed to ensure that the acting user could actually see the new owning organization. Signed-off-by: Andrew Thornton <[email protected]> * change IsUserPartOfOrg everywhere Co-authored-by: zeripath <[email protected]>
zeripath
added
the
topic/security
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assessing whether a private organization was visible to a user before allowing transfer was incorrect due to testing membership the wrong way round.
This PR fixes this issue and renames the function performing the test to be clearer.
Further looking at the API for transfer repository - no testing was performed to ensure that the acting user could actually see the new owning organization.
Signed-off-by: Andrew Thornton [email protected]