Skip to content

Fix Git hooks not being executed on Windows when running as a service #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2017
Merged

Fix Git hooks not being executed on Windows when running as a service #1149

merged 1 commit into from
Mar 9, 2017

Conversation

andreynering
Copy link
Contributor

Closes #1139

/cc @lunny

@andreynering andreynering added this to the 1.1.0 milestone Mar 8, 2017
@lunny
Copy link
Member

lunny commented Mar 9, 2017

But I don't think this is great. Maybe add SKIP_MINWINSVC env on https://github.com/go-gitea/gitea/blob/master/cmd/serv.go#L118. Then we could not change the vendor files.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 9, 2017
@lunny
Copy link
Member

lunny commented Mar 9, 2017

Anyway, since minisvc has been copied to module, LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 9, 2017
@appleboy
Copy link
Member

appleboy commented Mar 9, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2017
@lunny lunny merged commit d2b2881 into go-gitea:master Mar 9, 2017
@andreynering andreynering deleted the windows-fix-git-hooks-on-service branch March 9, 2017 10:48
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Git hooks are not being executed on Windows when running as a service
4 participants
@andreynering @lunny @appleboy @tboerger