Fix appearance of unsigned sha box in view_list #10543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the fix in go-gitea#10511 was slightly incorrect and placed the detail box at one level too far out. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
topic/ui
Codecov Report
@@ Coverage Diff @@
## master #10543 +/- ##
==========================================
- Coverage 43.76% 43.74% -0.03%
==========================================
Files 586 586
Lines 81764 81764
==========================================
- Hits 35783 35765 -18
- Misses 41543 41557 +14
- Partials 4438 4442 +4
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Feb 29, 2020
GiteaBot
added
lgtm/need 1
jaqra
approved these changes
Feb 29, 2020
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 29, 2020
Unfortunately the fix in go-gitea#10511 was slightly incorrect and placed the detail box at one level too far out. Signed-off-by: Andrew Thornton <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
Feb 29, 2020
Unfortunately the fix in #10511 was slightly incorrect and placed the detail box at one level too far out. Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the fix in #10511 was slightly incorrect and placed the
detail box at one level too far out.
Signed-off-by: Andrew Thornton [email protected]