Skip to content

Split view diff with arc-green theme have white background #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 7 tasks
relta-c opened this issue Jul 22, 2019 · 1 comment · Fixed by #7587
Closed
2 of 7 tasks

Split view diff with arc-green theme have white background #7568

relta-c opened this issue Jul 22, 2019 · 1 comment · Fixed by #7587
Labels
Milestone

Comments

@relta-c
Copy link

relta-c commented Jul 22, 2019

  • Gitea version (or commit ref): v1.9.0-rc2
  • Git version: 2.16.4-lp151.3.4
  • Operating system: openSUSE Leap 15.1
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist:

Description

Split view diff with arc-green will display white background in added line.
I'm not really a web developer so I don't really know much about CSS and stuff
but after digging around a bit it seem to be a result from this line in arc-green.less:

.repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(1),
.repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(2),
.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(3), <<
.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(4),
.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(5),
.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(6) {
background-color: #2a2e3a;
}

Change it to
.repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(3),
seem to fix the issue.

Screenshots

Screenshot_20190723_014402

@silverwind
Copy link
Member

Probably a regression from #7279.

zeripath added a commit to zeripath/gitea that referenced this issue Jul 23, 2019
lunny pushed a commit that referenced this issue Jul 23, 2019
@lunny lunny added the type/bug label Jul 23, 2019
@lunny lunny added this to the 1.9.0 milestone Jul 23, 2019
zeripath added a commit to zeripath/gitea that referenced this issue Jul 23, 2019
zeripath added a commit that referenced this issue Jul 23, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants