Skip to content

Add searching capabilities to the tags page #31998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bsofiato opened this issue Sep 6, 2024 · 3 comments · Fixed by #32045
Closed

Add searching capabilities to the tags page #31998

bsofiato opened this issue Sep 6, 2024 · 3 comments · Fixed by #32045
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.23.0

Comments

@bsofiato
Copy link
Contributor

bsofiato commented Sep 6, 2024

Feature Description

How do you feel about adding search functionality to /{org}/{repo}/tags?
I think it would greatly enhance the UX when dealing with repos with huge amounts of tags. Moreover, both /{org}/{repo}/commits/** and /{org}/{repo}/branches already support searching, so why not ? :)

If you guys are cool with it, I can try to provide a PR for it.

Screenshots

No response
@bsofiato bsofiato added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Sep 6, 2024
@lunny
Copy link
Member

lunny commented Sep 6, 2024

Yes, it's great to have a search feather there. Please send a PR and I'm glad to review it.

@bsofiato
Copy link
Contributor Author

bsofiato commented Sep 9, 2024

Cool @lunny, gonna work on it during the week :)

@bsofiato bsofiato mentioned this issue Sep 15, 2024
Merged
@bsofiato
Copy link
Contributor Author

bsofiato commented Sep 15, 2024 •
edited
Loading

Hey @lunny, I've just created the #32045 that implements this feature. :)

@lunny lunny added this to the 1.23.0 milestone Sep 15, 2024
@lunny lunny closed this as completed in 7dde3e6 Sep 17, 2024
matera-bs pushed a commit to matera-ar/gitea that referenced this issue Sep 19, 2024
@bsofiato @matera-bs
[Cherry picked from v1.22.3] Included tag search capabilities (go-git…
707e82b 
…ea#32045)

Resolves go-gitea#31998

The first screenshot shows the tag page without any filter being
applied:

![image](https://github.com/user-attachments/assets/eac0e51c-9e48-42b2-bb1c-a25896ca40cb)

The second one, shows the page when the given filter returns no tag:

![image](https://github.com/user-attachments/assets/98df191e-1a7b-4947-b0ef-4987a0293c3e)

The last one shows a single tag being filtered:

![image](https://github.com/user-attachments/assets/79c7e05e-8c86-4f06-b17e-15818b7b9291)

Signed-off-by: Bruno Sofiato <[email protected]>
@matera-bs matera-bs mentioned this issue Sep 19, 2024
Merged
matera-bs added a commit to matera-ar/gitea that referenced this issue Sep 19, 2024
@matera-bs @bsofiato
[Cherry picked from v1.22.3] Included tag search capabilities (go-git…
151d8cd 
…ea#32045) (#3)

Resolves go-gitea#31998

The first screenshot shows the tag page without any filter being
applied:

![image](https://github.com/user-attachments/assets/eac0e51c-9e48-42b2-bb1c-a25896ca40cb)

The second one, shows the page when the given filter returns no tag:

![image](https://github.com/user-attachments/assets/98df191e-1a7b-4947-b0ef-4987a0293c3e)

The last one shows a single tag being filtered:

![image](https://github.com/user-attachments/assets/79c7e05e-8c86-4f06-b17e-15818b7b9291)

Signed-off-by: Bruno Sofiato <[email protected]>
Co-authored-by: Bruno Sofiato <[email protected]>
matera-bs added a commit to matera-ar/gitea that referenced this issue Oct 29, 2024
@matera-bs @bsofiato
[Cherry picked from v1.23.0 - Tentative] Included tag search capabili…
8dc3cce 
…ties (go-gitea#32045) (#3)

Resolves go-gitea#31998

The first screenshot shows the tag page without any filter being
applied:

![image](https://github.com/user-attachments/assets/eac0e51c-9e48-42b2-bb1c-a25896ca40cb)

The second one, shows the page when the given filter returns no tag:

![image](https://github.com/user-attachments/assets/98df191e-1a7b-4947-b0ef-4987a0293c3e)

The last one shows a single tag being filtered:

![image](https://github.com/user-attachments/assets/79c7e05e-8c86-4f06-b17e-15818b7b9291)

Signed-off-by: Bruno Sofiato <[email protected]>
Co-authored-by: Bruno Sofiato <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 16, 2024
matera-bs added a commit to matera-ar/gitea that referenced this issue Dec 17, 2024
@matera-bs @bsofiato
[Cherry picked from v1.23.0 - Tentative] Included tag search capabili…
b964533 
…ties (go-gitea#32045) (#3)

Resolves go-gitea#31998

The first screenshot shows the tag page without any filter being
applied:

![image](https://github.com/user-attachments/assets/eac0e51c-9e48-42b2-bb1c-a25896ca40cb)

The second one, shows the page when the given filter returns no tag:

![image](https://github.com/user-attachments/assets/98df191e-1a7b-4947-b0ef-4987a0293c3e)

The last one shows a single tag being filtered:

![image](https://github.com/user-attachments/assets/79c7e05e-8c86-4f06-b17e-15818b7b9291)

Signed-off-by: Bruno Sofiato <[email protected]>
Co-authored-by: Bruno Sofiato <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging a pull request may close this issue.

Included tag search capabilities bsofiato/gitea
2 participants
@lunny @bsofiato