Skip to content

Invalid value separators in notification email headers #22815

Open
@hg

Description

@hg

Description

Hi,

I've been trying out email replies merged in #22056.

They are breaking aerc (the email client) with this message:

worker.go:536: could not get message info: mail: missing '<' in msg-id

https://github.com/emersion/go-message/blob/master/mail/header.go#L174-L181

Naturally, I thought the issue was with the client, but after digging for a while found out that gitea joins email header values (References, List-Unsubscribe, probably others) using commas as separators.

References: <xxx/yyy/issues/[email protected]>,
 <[email protected]>

List-Unsubscribe: <https://git.example.com/xxx/yyy/issues/42>,
  <mailto:[email protected]>

I don't think this is valid email. RFC5322 requires CFWS to separate header values (which is either comments or whitespace), and does not allow commas.

Could you please confirm if this is a bug?

Gitea Version

1.19.0+dev-444-g2c6cc0b8c

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker, gitea/gitea:dev

Database

PostgreSQL

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions