Skip to content

Pulse the Review button when a comment is added to a review #19611

Closed
@jtran

Description

@jtran

Feature Description

As a new user unfamiliar with pull request reviews, I would like the Review button to have a visual indicator (like a pulse) each time a comment is added to a review. The problem this helps deal with is teaching new users that when a comment is added to a review, it is not shown to any other users until the review is submitted.

As far as I know, there's currently very little (nothing?) that helps teach users about this concept. Users are expected to just know how it works. I think that some kind of visual indicator when a comment is added to a review would help communicate that further action of submitting the review is required. Something like a pulse is nice because it doesn't require that users read, which few people do.

GitHub's interface both pulses the review button and increments a counter of the number of pending comments in the button's text. I think the counter is nice, but the pulse is a prerequisite since new users may not know to look for the counter.

Screenshots

pusle-review3.mov

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/featureCompletely new functionality. Can only be merged if feature freeze is not active.type/proposalThe new feature has not been accepted yet but needs to be discussed first.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions