Internal server error when clicking "Show More" on large PR diff #17731
Labels
Comments
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Nov 19, 2021
Unfortunately due to a misread on my behalf I missed that git diff only learned --skip-to in version 2.31.0. Thus this functionality was not working on older versions of git. This PR adds a handler that simply allows for us to skip reading the diffs until we find the correct file to skip to. Fix go-gitea#17731 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this issue
Nov 20, 2021
Unfortunately due to a misread on my behalf I missed that git diff only learned --skip-to in version 2.31.0. Thus this functionality was not working on older versions of git. This PR adds a handler that simply allows for us to skip reading the diffs until we find the correct file to skip to. Fix #17731 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this issue
Mar 28, 2022
Unfortunately due to a misread on my behalf I missed that git diff only learned --skip-to in version 2.31.0. Thus this functionality was not working on older versions of git. This PR adds a handler that simply allows for us to skip reading the diffs until we find the correct file to skip to. Fix go-gitea#17731 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Gitea Version
1.16.0+dev-558-ga8fd76557
Git Version
2.18.0
Operating System
Windows
How are you running Gitea?
Built myself.
Database
No response
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
https://gist.github.com/jpraet/3803f61d48e8db2ee12cfaa354a91135
Description
https://try.gitea.io/jpraet-org/test-repo/pulls/1/files -> click "Show More".
In network tab of browser console:
XHR GET https://try.gitea.io/jpraet-org/test-repo/pulls/1/files?skip-to=101.txt&file-only=true
[HTTP/2 500 Internal Server Error 190ms]
Screenshots
No response
The text was updated successfully, but these errors were encountered: