Repositories w/ capital letters in their names show up as unadopted

[emichael]

• Gitea version (or commit ref): 1.14.1 (Docker)
• Git version: N/A
• Operating system: N/A
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
    I don't have admin access on that instance.
• Log gist: Nothing in logs

Description

1. Create a repository through the web interface with capital letters in its name.
2. Go to the admin interface, Repositories, Unadopted Repositories, Search
3. That repository will show up in the list, even though it's already imported into Gitea.

Screenshots

[zeripath]

Gitea does not create repositories with capital names, non bare or repositories without the .git suffix. It can only adopt repositories that look like they were made by it.

If we adopted repositories that did not meet those requirements there would be multiple issues.

The rules for adoption are strict and necessarily so.

[zeripath]

Oh sorry I got the wrong end of the stick here!

[emichael]

It's very likely just a missing toLower() or some such function when matching existing repo names in Gitea against filesystem names. Probably a one line fix.

[zeripath]

The bug is here:

gitea/modules/repository/adopt.go

Line 231 in ab77a24

if repo.Name == name {

Which should be repo.LowerName not repo.Name

[zeripath]

Feel free to put up a PR. The rest of the code is doing the correct thing - that one sneaked through by accident.