Install fails if admin username is invalid

[PatrickMennig]

• Gitea version (or commit ref): 1.1.0
• Git version: 2.1.4
• Operating system: Debian 8
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

When installing gitea I created a new admin user (name: master) via the web interface (:3000/install) and set a password containing an exclamation mark ("!"). The install page never redirected me to the main page, after a while I just opened the main page in another browser window and tried to log in. It always failed saying wrong username / password. I confirmed that the password was correct several times. I then changed install_lock to false, revisited /install and gave a password without special chars, this worked like a charm.

...

Screenshots

[pgaskin]

I had this issue, but even though it hung on the redirect, it still worked afterwards.

[bkcsoft]

Sounds like we need more tests

[Avalancs]

Yesterday I did an install of 1.1.1 and didn't use any special characters in the password (used something very similar to Password123) and didn't get redirected. When I navigated to the login page manually and tried to log in I would get invalid username/password.

I looked into the database, and the user was actually not created. As a workaround I created the user by command line of gitea-1.1.1-amd64...exe So it might not necessarily be the password?

The specs:
Gitea version (or commit ref): 1.1.1
Git version: git2.12.2.windows.2
Operating system: Windows 10
Database: MySQL

[Avalancs]

Specs:
Gitea version (or commit ref): 1.1.1
Git version: git2.12.2.windows.2
Operating system: Windows Server 2016 Standard
Database: MySQL

Did another install for reproducing another issue, and I've noticed that when you try to create a user called "admin" from the admin panel, it says "Username 'admin' is reserved." But this warning does not come up in the install page if you try to name the new user "admin". This should be the reason why I did not get the user created in my last post, because I named it admin.

[hargut]

Same here, tried to install 1.3.0 with postgres database backend on a separate db server, and create the admin user during the install with a special char in the password.
The redirect did not work and the user was not created. Creating the user as first user after refreshing the page worked.

It seems that the 'admin' name is with 1.3.0 also blocked when trying to register the first user. The 'admin' name did also not work during the setup process. Both ways a message appeared that the "Username 'admin' is reserved."