Skip to content

Add branch name in Status and ChangesComponent cleanup #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2020
Merged

Add branch name in Status and ChangesComponent cleanup #375

merged 3 commits into from
Oct 26, 2020

Conversation

remique
Copy link
Contributor

@remique remique commented Oct 26, 2020

This fixes #365.

Still not sure if lookup in update function is done correctly:

self.git_branch_name.lookup().map(Some).unwrap_or(None)

Other than that I think everything is okay now :)

extrawurst
extrawurst requested changes Oct 26, 2020
View reviewed changes
@remique
Copy link
Contributor Author

remique commented Oct 26, 2020

Got rid of the update function as well as title string in ChangesComponent as it was never used anymore.

@extrawurst
Copy link
Collaborator

@remique looks good to me, will merge once the CI is done - thanks for the contribution!! 🥳

@extrawurst extrawurst merged commit 35f3a25 into gitui-org:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extrawurst extrawurst extrawurst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

better 'current branch' visualisation
2 participants
@remique @extrawurst