sign with ssh key in disk #2175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanganto
force-pushed
the
ssh-sign-w-trait
branch
from
93fc676 to
e22ca15
Compare
yanganto
force-pushed
the
ssh-sign-w-trait
branch
from
e22ca15 to
32299e5
Compare
|
Thanks for you contribution @yanganto ! 🥳 |
4 tasks
jirutka
reviewed
May 18, 2024
| @@ -27,6 +28,7 @@ rayon = "1.10" | |||
| rayon-core = "1.12" | |||
| scopetime = { path = "../scopetime", version = "0.1" } | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| ssh-key = { version = "0.6.4", features = ["crypto", "encryption"] } | |||
There was a problem hiding this comment.
This has added dozens of extra dependencies and increased the binary size by ~1 MiB!
There was a problem hiding this comment.
Wow, I did not realize this, what is your suggestion? Is an optional feature good from your end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #1149 #2173
ref: #2047 #2023
It changes the following:
user.signingKeyof gitconfig will be used to sign the commitI followed the checklist:
make checkwithout errors