Skip to content

Take advantage of universal newlines. #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2019
Merged

Take advantage of universal newlines. #927

merged 1 commit into from
Sep 28, 2019

Conversation

uri-canva
Copy link
Contributor

Universal newlines means that the streams will split on \r just like any other kind of newline, so there is no need to handle them differently.

@uri-canva
Copy link
Contributor Author

DeepSource failed because I changed some lines with pre-existing issues.

@Byron Byron added this to the v3.0.3 - Bugfixes milestone Sep 28, 2019
@Byron
Copy link
Member

Byron commented Sep 28, 2019

What a catch! Thanks a lot!
Quite amazing that despite me having implemented complex 'sub-line' handling, there is no test that actually verifies it 😅

@Byron Byron merged commit 882ebb1 into gitpython-developers:master Sep 28, 2019
@uri-canva uri-canva deleted the cr-newlines branch September 28, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v3.0.3 - Bugfixes
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-canva @Byron