Skip to content

feat: gracefully handle partial failure for multiple accounts #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 2, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jul 27, 2024

Closes #423

simulated multiple account setup with a partial failure

Screenshot 2024-07-28 at 7 51 40 AM Screenshot 2024-07-28 at 10 09 37 AM Screenshot 2024-07-28 at 10 18 18 AM

@setchy setchy added this to the Release 5.12.0 milestone Jul 27, 2024
@github-actions github-actions bot added the enhancement New feature or enhancement to existing functionality label Jul 27, 2024
@setchy setchy marked this pull request as draft July 27, 2024 22:53
@setchy setchy marked this pull request as ready for review July 28, 2024 00:22
@setchy setchy marked this pull request as draft July 28, 2024 00:26
@setchy
Copy link
Member Author

setchy commented Jul 28, 2024

updated to set the account header row background as red if an account has encountered errors

Example
Screenshot 2024-07-28 at 4 34 16 PM

@setchy setchy marked this pull request as ready for review July 28, 2024 06:36
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@setchy setchy merged commit 82b5ce4 into main Aug 2, 2024
12 checks passed
@setchy setchy deleted the feature/multi-account-partial-failure branch August 2, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitify does not send any notification from github.com if it is not able to access to GitHub Enterprise server.
2 participants