-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Go: extract and expose struct tags, interface method IDs #17357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
smowton
merged 23 commits into
github:main
from
smowton:smowton/feature/go-indistinguishable-types
Oct 9, 2024
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
dcbb66d
Go: extract and expose struct tags, interface method IDs
smowton 9bb2a4b
Change note
smowton 22ed2f9
Autoformat CodeQL
smowton 5d14070
Fix test file
smowton 7a7ff4a
Apply review comments
smowton e1963a5
autoformat
smowton 442e581
Update stats
smowton fd615fb
Prevent bad magic
smowton 1511927
Remove unnecessary table population on upgrade
smowton d04a0f4
Add note explaining how to regenerate dbscheme
smowton 74cba90
Optimise join orders
smowton c1a1edf
Autoformat
smowton 288e0ec
component_tags -> struct_tags
smowton 0f95a8d
Clarify doc
smowton ab99509
Rework interface for querying private interface method ids
smowton 36a0318
Further optimisation
smowton 365ccf4
autoformat
smowton bf5ba33
Improve join orders for top 5 perf regressions in QA
smowton ed9a6bd
Further join order optimisations
smowton c79da8b
Avoid pathological case where getExampleMethodName picks a very commo…
smowton d401891
copyedit
smowton 629a7a6
Further optimise guardingFunction: remove redundant condition, and or…
smowton 837387a
Re-optimise isSensitive routine
smowton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
546 changes: 546 additions & 0 deletions
546
go/downgrades/4bd57e093275e5e892dfb16b55ed4bd76ea662be/go.dbscheme
Large diffs are not rendered by default.
Oops, something went wrong.
552 changes: 552 additions & 0 deletions
552
go/downgrades/4bd57e093275e5e892dfb16b55ed4bd76ea662be/old.dbscheme
Large diffs are not rendered by default.
Oops, something went wrong.
5 changes: 5 additions & 0 deletions
5
go/downgrades/4bd57e093275e5e892dfb16b55ed4bd76ea662be/upgrade.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
description: Remove component-tags and interface-method-id tables | ||
compatibility: full | ||
|
||
struct_tags.rel: delete | ||
interface_private_method_ids.rel: delete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
category: minorAnalysis | ||
--- | ||
* Added member predicates `StructTag.hasOwnFieldWithTag` and `Field.getTag`, which enable CodeQL queries to examine struct field tags. | ||
* Added member predicate `InterfaceType.hasPrivateMethodWithQualifiedName`, which enables CodeQL queries to distinguish interfaces with matching non-exported method names that are declared in different packages, and are therefore incompatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.