Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Polish checks list in pull request details #1813

Merged
merged 9 commits into from
Jul 31, 2018
Merged

Polish checks list in pull request details #1813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a7775c
Adjust some row/column definitions
donokuda Jul 26, 2018
9c6c5da
make the avatar smaller
donokuda Jul 26, 2018
276549b
Hide this description
donokuda Jul 26, 2018
5c2c0f7
Use the primitive dot octicon for pending checks
donokuda Jul 26, 2018
5edce94
Add a lil' bit of right margin
donokuda Jul 26, 2018
9db38a9
Try out a GridView
donokuda Jul 30, 2018
d279d06
Use IsSharedSizeScope so that Grid Rendering works
donokuda Jul 30, 2018
86b3942
Remove extra line
donokuda Jul 30, 2018
b0cdcf0
Fix text color for dark theme
donokuda Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,25 @@

<Grid>
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnZero" />
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnOne" />
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnTwo" />
<ColumnDefinition Width="*"/>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition MinWidth="50" Width="Auto" SharedSizeGroup="ColumnFour" />
</Grid.ColumnDefinitions>

<Grid.RowDefinitions>
<RowDefinition Height="32"/>
<RowDefinition MaxHeight="32"/>
</Grid.RowDefinitions>

<ghfvs:OcticonImage Grid.Column="0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
<ghfvs:OcticonImage Grid.Column="0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
<ghfvs:OcticonImage Grid.Column="0" Icon="clock" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
<Image Grid.Column="1" Source="{Binding Avatar}"/>
<Label Grid.Column="2" Content="{Binding Title}"/>
<Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
<ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
<ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
<ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
<Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
<Label Grid.Column="2" Foreground="{DynamicResource VsBrush.WindowText}" Content="{Binding Title}"/>
<!--
<Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
-->
<Label Grid.Column="4" HorizontalAlignment="Right">
<Hyperlink ToolTip="{Binding DetailsUrl}" Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
</Label>
Expand Down
5 changes: 5 additions & 0 deletions src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,11 @@
Margin="0 8 0 0"
ghfvs:ScrollingVerticalStackPanel.IsFixed="true">
<ItemsControl ItemsSource="{Binding Checks}" Margin="0 4 12 4">
<ItemsControl.ItemsPanel>
<ItemsPanelTemplate>
<StackPanel Grid.IsSharedSizeScope="True" />
</ItemsPanelTemplate>
</ItemsControl.ItemsPanel>
<ItemsControl.ItemTemplate>
<DataTemplate>
<local:PullRequestCheckView/>
Expand Down
2 changes: 1 addition & 1 deletion src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListItemView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
</TextBlock>
<ghfvs:OcticonImage Icon="check" Foreground="#2cbe4e" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
<ghfvs:OcticonImage Icon="x" Foreground="#cb2431" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
<ghfvs:OcticonImage Icon="clock" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
<ghfvs:OcticonImage Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
</StackPanel>
</Grid>
</Grid>
Expand Down