Skip to content

Russian translate #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Russian translate #1343

wants to merge 6 commits into from

Conversation

vhot2076
Copy link
Contributor

I made a Russian translate here.
For fix some troubles in tables after change words size when translation, I`m add to .css "white-space: nowrap;".
I'm adding .gitattributes for fix bug auto-conversion linux files *.sh when export by git-for-window.

@flaix
Copy link
Member

flaix commented Jul 16, 2021

Hi Vladimir!

Thank you for providing a Russian translation for Gitblit. This is great!

Could you give me an example where you saw problems in tables? Did you test that your CSS changes work with the other languages?

I'd like to offer you some tips for future contributions to Open Source repositories on GitHub. These can help you and other maintainers integrate your additions easily.
When you want to get your changes merged to another repository, always work on a new, separate branch. Not on the main (master) branch. This has multiple benefits. For one, additional work can be pushed to that branch. Also, the branch can be rebased onto the main branch, when the main branch has meanwhile moved on.
Clean up your branch when you feel that you are done with your changes. For example in this case, the first three commits could be squashed into one commit, as well as the last two commits.
If you do multiple unrelated changes, prefer not to mix them into one merge request. This way maintainers have the chance to accept some changes while declining others, or to add some changes earlier and others later.

I would like to integrate your changes, but I would have to clean up the branch a bit. Let me know if you would like to do that, which would keep the commits under your name.

@flaix flaix added this to the 1.9.2 milestone Nov 2, 2021
@flaix flaix closed this in edd1e67 Nov 3, 2021
@flaix
Copy link
Member

flaix commented Nov 3, 2021

I have merged the translation part of this. Thank you for contributing!
I was not able to reproduce the HTML bug. If it still exists, please open another pull request with some more information, maybe a screenshot or a description where it occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants