-
-
Notifications
You must be signed in to change notification settings - Fork 6
Fix: add guard for dev mode #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ghostdevv
merged 8 commits into
ghostdevv:main
from
cainthebest:fix/add-guard-for-dev-mode
Feb 24, 2023
Merged
Fix: add guard for dev mode #165
ghostdevv
merged 8 commits into
ghostdevv:main
from
cainthebest:fix/add-guard-for-dev-mode
Feb 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0c136ba The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR
|
ghostdevv
requested changes
Feb 23, 2023
Co-authored-by: Willow (GHOST) <[email protected]>
ghostdevv
reviewed
Feb 24, 2023
Co-authored-by: Willow (GHOST) <[email protected]>
ghostdevv
approved these changes
Feb 24, 2023
Awesome ty! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Body
This pull request adds a new check to ensure that developers who enable dev mode with
dev.global
have at least one guild ID provided in thedev.guilds
array. If there are no guild IDs provided, the code will throw an error.This check also takes into account any dev commands that may be present in the commands set. If there are any dev commands, but no guild IDs are provided, the code will also throw an error