Skip to content

Fix: add guard for dev mode #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 24, 2023

Conversation

cainthebest
Copy link
Contributor

@cainthebest cainthebest commented Feb 23, 2023

Checklist

Body

This pull request adds a new check to ensure that developers who enable dev mode with dev.global have at least one guild ID provided in the dev.guilds array. If there are no guild IDs provided, the code will throw an error.

This check also takes into account any dev commands that may be present in the commands set. If there are any dev commands, but no guild IDs are provided, the code will also throw an error

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

🦋 Changeset detected

Latest commit: 0c136ba

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "dev" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@cainthebest cainthebest changed the title Fix/add guard for dev mode Fix: add guard for dev mode Feb 23, 2023
@ghostdevv
Copy link
Owner

Awesome ty!

@ghostdevv ghostdevv merged commit 07397ff into ghostdevv:main Feb 24, 2023
@github-actions github-actions bot mentioned this pull request Feb 24, 2023
@cainthebest cainthebest deleted the fix/add-guard-for-dev-mode branch February 24, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants