Skip to content

[naga]: Remove indexmap/std from wgsl-in #7586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bushrat011899
Copy link
Contributor

Connections

Description
Reduces blockers to no_std support in wgsl-in feature

Testing
CI

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry. N/A

Notes

DiagnosticFilterMap will now be less resilient to DoS attacks since it uses FastIndexMap instead of IndexMap. I don't believe this is a substantial issue, but I'm calling it out here in case my assumption there is incorrect.

@bushrat011899 bushrat011899 requested a review from a team as a code owner April 21, 2025 11:03
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ErichDonGubler ErichDonGubler merged commit f79cf6e into gfx-rs:trunk Apr 21, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants