Make std usage optional for wgpu-core.
#7279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpreid
commented
Mar 6, 2025
kpreid
commented
Mar 6, 2025
…ional. Now, when `cfg(not(debug_assertions))`, there is no `SNATCH_LOCK_TRACE` thread local, and `LockTrace` has no data fields.
kpreid
force-pushed
the
core-no-std
branch
2 times, most recently
from
6481f48 to
1b3d714
Compare
cwfitzgerald
approved these changes
Mar 6, 2025
Adds a `std` feature, enabled by default, to `wgpu-core`. When that feature is disabled, the following functionality is not available: * `Send + Sync` for resources. * `trace` feature. * `observe_locks` feature. * Snatch lock recursive locking assertion.
I agree (and the mutually exclusive distinction between “no-std” and “web” needs to change), but it’ll be easier to do then than now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Part of implementing #6826. Followup to #7189.
Description
Adds a
stdfeature, enabled by default, towgpu-core. When that feature is disabled, the following functionality is not available:Send + Syncfor resources.tracefeature.observe_locksfeature.Also,RawStringstops tracking the OS definition and is always*const u8. This is a bad idea and will breakwgpu’s code on platforms wherec_char = i8, but I don’t know what should be done instead; I’m not familiar with the reasons forbundle_ffi’s design. Please advise.Testing
wgpu-core’s dependencies (notablynaga) still requirestd, so this can’t be fully tested yet, but the test suite still passes, and buildingwgpu-corewith the feature disabled succeeds.Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.