tests: fix test_stacktrace_big_recursion failure due to argv #4346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes I see the test failing because the event contains `extras` with `sys.argv` key in addition to `exception`. There's probably some state leaking between tests, but regardless this patch should make the test case slightly more robust. Signed-off-by: Ihar Hrachyshka <[email protected]>
booxter
commented
Apr 29, 2025
sentrivana
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
Thank you @booxter!
We definitely have some stuff leaking between the tests, we need to allocate proper time to figure out how to fix that. Your fix is definitely a good improvement though!
Feel free to also bump the timeout in this PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4346 +/- ##
==========================================
- Coverage 80.32% 80.29% -0.03%
==========================================
Files 142 142
Lines 15933 15933
Branches 2725 2725
==========================================
- Hits 12798 12794 -4
- Misses 2262 2263 +1
- Partials 873 876 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I see the test failing because the event contains
extraswith
sys.argvkey in addition toexception. There's probably somestate leaking between tests, but regardless this patch should make the
test case slightly more robust.
Signed-off-by: Ihar Hrachyshka [email protected]