fix(debug): Do not consider parent loggers for debug logging #4286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
requested review from
sentrivana
and removed request for
a team
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4286 +/- ##
==========================================
+ Coverage 79.51% 79.53% +0.02%
==========================================
Files 142 142
Lines 15907 15907
Branches 2723 2723
==========================================
+ Hits 12648 12652 +4
+ Misses 2390 2389 -1
+ Partials 869 866 -3
|
This reverts commit 3793084, which made the SDK consider parent loggers when determining if the Sentry SDK should log debug messages. However, we should not consider parent loggers, since we only want the SDK to log debug messages when configured to do so via `debug=True` (in `sentry_sdk.init`), the `SENTRY_DEBUG` environment variable, or via a specific logger configuration for `sentry_sdk.errors`. With 3793084, a custom root logger configuration would also cause SDK logs to be emitted. The issue 3793084 was meant to fix (#3944) appears to have been caused by user error, not a bug in the SDK. Fixes #4266
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-logging
branch
from
0b21ae2 to
cf235b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3793084, which made the SDK consider parent loggers when determining if the Sentry SDK should log debug messages.
However, we should not consider parent loggers, since we only want the SDK to log debug messages when configured to do so via
debug=True(insentry_sdk.init), theSENTRY_DEBUGenvironment variable, or via a specific logger configuration forsentry_sdk.errors. With 3793084, a custom root logger configuration would also cause SDK logs to be emitted.The issue 3793084 was meant to fix (#3944) will require a different fix.
Fixes #4266