-
Notifications
You must be signed in to change notification settings - Fork 548
feat(transport): Add a timeout #4252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4252 +/- ##
==========================================
- Coverage 79.54% 79.53% -0.01%
==========================================
Files 142 142
Lines 15905 15907 +2
Branches 2723 2723
==========================================
Hits 12652 12652
- Misses 2385 2389 +4
+ Partials 868 866 -2
|
You missed the second pool options implementation around lines 772 for HTTP2 I guess |
And just a side note - I don't know what are the Sentry SaaS response times but 5 seconds might be too little for the read timeout. I think other software uses 15 seconds by default. |
Gotcha, still working on this, not final yet -- planning on adding the timeout to the other transport and also need to decide on a good default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! 🚀
For some reason, we don't define any timeouts in our default transport(s).
With this change:
Backend SDKs in general set wildly different timeouts, from 30s in Go to <5s in Ruby or PHP. I went for the higher end of the range here since this is mainly meant to prevent the SDK preventing process shutdown like described in #4247 -- we don't want to cut off legitimate requests that are just taking a long time. (I was considering going even higher, maybe to 60s -- but I think 30s is a good first shot at this and we can always change it later.)