-
Notifications
You must be signed in to change notification settings - Fork 547
Deprecate set_measurement()
API.
#3934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3934 +/- ##
==========================================
- Coverage 80.33% 80.26% -0.07%
==========================================
Files 142 142
Lines 15933 15935 +2
Branches 2725 2725
==========================================
- Hits 12800 12791 -9
- Misses 2261 2268 +7
- Partials 872 876 +4
|
…tsentry/sentry-python into antonpirker/deprecate-set-measurement
As this is kind of in sleep-mode right now, we keep this PR open but will not merge it right now. See: https://github.com/getsentry/projects/issues/73 |
Picking this up again, Daniel G said we should deprecated now and remove in 3.0. |
…tsentry/sentry-python into antonpirker/deprecate-set-measurement
Deprecate
set_measurement()
. This will be replaced byset_data()
which internally is using the Otelset_attribute()
.Fixes #3074