Skip to content

Run 2.7 tests in CI again #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 20, 2023
Merged
39 changes: 36 additions & 3 deletions .github/workflows/test-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10","3.11"]
python-version: ["3.5","3.6","3.7","3.8","3.9","3.10","3.11"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
Expand Down Expand Up @@ -69,14 +69,47 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml

test-py27:
name: common, python 2.7, ubuntu-20.04
runs-on: ubuntu-20.04
container: python:2.7
timeout-minutes: 30

steps:
- uses: actions/checkout@v3

- name: Setup Test Env
run: |
pip install coverage "tox>=3,<4"

- name: Test common
uses: nick-fields/retry@v2
with:
timeout_minutes: 15
max_attempts: 2
retry_wait_seconds: 5
shell: bash
command: |
set -x # print commands that are executed
coverage erase

# Run tests
./scripts/runtox.sh "py2.7-common" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch &&
coverage combine .coverage* &&
coverage xml -i

check_required_tests:
name: All common tests passed or skipped
needs: test
needs: [test, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
3 changes: 2 additions & 1 deletion .github/workflows/test-integration-aiohttp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml


check_required_tests:
name: All aiohttp tests passed or skipped
needs: test
Expand All @@ -79,4 +80,4 @@ jobs:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
3 changes: 2 additions & 1 deletion .github/workflows/test-integration-arq.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml


check_required_tests:
name: All arq tests passed or skipped
needs: test
Expand All @@ -79,4 +80,4 @@ jobs:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
3 changes: 2 additions & 1 deletion .github/workflows/test-integration-asgi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml


check_required_tests:
name: All asgi tests passed or skipped
needs: test
Expand All @@ -79,4 +80,4 @@ jobs:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
3 changes: 2 additions & 1 deletion .github/workflows/test-integration-aws_lambda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml


check_required_tests:
name: All aws_lambda tests passed or skipped
needs: test
Expand All @@ -79,4 +80,4 @@ jobs:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
3 changes: 2 additions & 1 deletion .github/workflows/test-integration-beam.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml


check_required_tests:
name: All beam tests passed or skipped
needs: test
Expand All @@ -79,4 +80,4 @@ jobs:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
39 changes: 36 additions & 3 deletions .github/workflows/test-integration-boto3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["2.7","3.6","3.7","3.8"]
python-version: ["3.6","3.7","3.8"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
Expand Down Expand Up @@ -69,14 +69,47 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml

test-py27:
name: boto3, python 2.7, ubuntu-20.04
runs-on: ubuntu-20.04
container: python:2.7
timeout-minutes: 30

steps:
- uses: actions/checkout@v3

- name: Setup Test Env
run: |
pip install coverage "tox>=3,<4"

- name: Test boto3
uses: nick-fields/retry@v2
with:
timeout_minutes: 15
max_attempts: 2
retry_wait_seconds: 5
shell: bash
command: |
set -x # print commands that are executed
coverage erase

# Run tests
./scripts/runtox.sh "py2.7-boto3" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch &&
coverage combine .coverage* &&
coverage xml -i

check_required_tests:
name: All boto3 tests passed or skipped
needs: test
needs: [test, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
39 changes: 36 additions & 3 deletions .github/workflows/test-integration-bottle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10","3.11"]
python-version: ["3.5","3.6","3.7","3.8","3.9","3.10","3.11"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
Expand Down Expand Up @@ -69,14 +69,47 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml

test-py27:
name: bottle, python 2.7, ubuntu-20.04
runs-on: ubuntu-20.04
container: python:2.7
timeout-minutes: 30

steps:
- uses: actions/checkout@v3

- name: Setup Test Env
run: |
pip install coverage "tox>=3,<4"

- name: Test bottle
uses: nick-fields/retry@v2
with:
timeout_minutes: 15
max_attempts: 2
retry_wait_seconds: 5
shell: bash
command: |
set -x # print commands that are executed
coverage erase

# Run tests
./scripts/runtox.sh "py2.7-bottle" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch &&
coverage combine .coverage* &&
coverage xml -i

check_required_tests:
name: All bottle tests passed or skipped
needs: test
needs: [test, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
39 changes: 36 additions & 3 deletions .github/workflows/test-integration-celery.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
python-version: ["3.5","3.6","3.7","3.8","3.9","3.10"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
Expand Down Expand Up @@ -69,14 +69,47 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml

test-py27:
name: celery, python 2.7, ubuntu-20.04
runs-on: ubuntu-20.04
container: python:2.7
timeout-minutes: 30

steps:
- uses: actions/checkout@v3

- name: Setup Test Env
run: |
pip install coverage "tox>=3,<4"

- name: Test celery
uses: nick-fields/retry@v2
with:
timeout_minutes: 15
max_attempts: 2
retry_wait_seconds: 5
shell: bash
command: |
set -x # print commands that are executed
coverage erase

# Run tests
./scripts/runtox.sh "py2.7-celery" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch &&
coverage combine .coverage* &&
coverage xml -i

check_required_tests:
name: All celery tests passed or skipped
needs: test
needs: [test, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
3 changes: 2 additions & 1 deletion .github/workflows/test-integration-chalice.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml


check_required_tests:
name: All chalice tests passed or skipped
needs: test
Expand All @@ -79,4 +80,4 @@ jobs:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml


check_required_tests:
name: All cloud_resource_context tests passed or skipped
needs: test
Expand All @@ -79,4 +80,4 @@ jobs:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
Loading