Set thread information on transaction from OpenTelemetry attributes #4478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
lcian
requested review from
adinauer,
romtsn,
stefanosiano and
markushi
as code owners
adinauer
approved these changes
Jun 11, 2025
| private void maybeTransferOtelThreadAttributes( | ||
| final @NotNull SpanData span, final @NotNull ITransaction sentryTransaction) { | ||
| final @NotNull Attributes attributes = span.getAttributes(); | ||
| final @Nullable Long threadId = attributes.get(ThreadIncubatingAttributes.THREAD_ID); |
There was a problem hiding this comment.
l for the future should we have some helper method to simply transfer an OTel attribute to Sentry since this uses the same key anyways.
There was a problem hiding this comment.
yeah I think it makes sense, I'll refactor
Co-authored-by: Alexander Dinauer <[email protected]>
lcian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
If present, grabs the thread attributes from the OTEL span to populate
transaction.data.thread.idandtransaction.data.thread.name.💡 Motivation and Context
Closes #4336
💚 How did you test it?
Manual testing.
📝 Checklist
sendDefaultPIIis enabled.