chore: Fix current clippy lints #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/sourcemaps.rs
Outdated
| // FIXME: This seems to be a false positive; clippy | ||
| // thinks we're doing `contains_key` followed by `insert`, | ||
| // but there's no `insert`. | ||
| #[allow(clippy::map_entry)] |
There was a problem hiding this comment.
Let's use an expect:
Suggested change
| #[allow(clippy::map_entry)] | |
| #[expect(clippy::map_entry)] |
Seems that there is already a PR which fixes this, so with the expect, we'll be alerted to remove the expect once the PR is released
There was a problem hiding this comment.
Good find, I totally missed that, I guess because I was only looking at open issues.
There was a problem hiding this comment.
Unfortunately we can't use expect here because the lint doesn't trip on stable.
There was a problem hiding this comment.
@loewenheim that is kinda sus, where are we linting with nightly?
I didn't think we linted with nightly in Sentry CLI
Co-authored-by: Daniel Szoke <[email protected]>
This reverts commit 0fbb0b8.
szokeasaurusrex
approved these changes
Apr 22, 2025
loewenheim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of them appears to be a false positive, though.