Scala 2.12.8 update #660
Scala 2.12.8 update #660
Conversation
cquiroz
force-pushed
the
scala-2.12.7
branch
3 times, most recently
from
c5f4ecc to
3ef4e89
Compare
|
Could we leave the Scala version at 2.12.6 for the client code and upgrade everything else? I talked to Seth and they're not sure what the plan is re: 11174. |
|
Hmm, i didn't think of that. let me try. of course it is a pity since that's the place where I want a faster compiler |
|
Somehow I can’t do this, I set the scala version for client but the compilation error persist Gotta love sbt |
Signed-off-by: Carlos Quiroz <[email protected]>
|
We can proceed with this PR now that scala 2.12.8 has been released. |
| className = SeqexecStyles.centeredCell.htmlClass, | ||
| cellRenderer = stepExposureRenderer(i.instrument) | ||
| ))) | ||
| .filter(_ => exposureVisible) |
There was a problem hiding this comment.
What happened to p.showExposure?
| .set(none)) | ||
| } else { | ||
| noChange | ||
| } | ||
|
|
||
| upd.getOrElse(noChange) |
There was a problem hiding this comment.
Just curious why this was changed, if you're going to get noChange anyways. (I didn't look in detail, note.)
There was a problem hiding this comment.
Same comment. Both codes seem equivalent, and IMO the old one looked better.
There was a problem hiding this comment.
I agreee, the new compiler emits a warning about unused variables in the old code. This seems a bug in the compiler and this is the workaround
There was a problem hiding this comment.
I’ll ask about this in the scala channels though
There was a problem hiding this comment.
This is a known issue in scala
scala/bug#11175
| @@ -202,7 +202,7 @@ object WebServerLauncher extends StreamApp[IO] with LogInitialization with Seqex | |||
| // I have taken this from the examples at: | |||
| // https://github.com/gvolpe/advanced-http4s/blob/master/src/main/scala/com/github/gvolpe/fs2/PubSub.scala | |||
| // It's not very clear why we need to run this inside a Scheduler | |||
| Scheduler[IO](corePoolSize = 4).flatMap { implicit S => | |||
There was a problem hiding this comment.
I've never seen implicit S like this before... can you explain to me briefly what it means / how it works?
There was a problem hiding this comment.
Good question. I think I took this from an example while doing the painful scalaz-stream to fs2 port. I don't honestly know 😢
There was a problem hiding this comment.
@tpolecat maybe knows?
|
In case you wonder why the update, scala 2.12.7/8 brings a compilation speed improvement of about 10% |
|
@cquiroz Excellent. Thanks for taking the time to answer my questions. I'm still confused, though, by what's happening with the |
Signed-off-by: Carlos Quiroz <[email protected]>
|
Keeping this branch up to date is kind of painful so i’d Rather merge now |
Scala 2.12.8 update
It would be nice upgrading to 2.12.7 to get better compilation speeds. This PR fixes almost evrything but there is a regression:
scala/bug#11174