feat: multipart upload #42
Conversation
source/ftrack_api/uploader.py
Outdated
| for i in range(retries): | ||
| try: | ||
| return await func(*args) | ||
| except Exception as e: |
There was a problem hiding this comment.
perhaps a bit broad? Maybe limit it to httpx.TimeoutException and httpx.HTTPStatusError in combination with exception.response.is_server_error()
| if self.parts_count > MAX_PARTS: | ||
| raise ValueError("File is too big.") | ||
|
|
||
| self.upload_id: Optional[str] = None |
There was a problem hiding this comment.
these are only used within start perhaps they do not need to be instance variables?
| @@ -81,7 +81,7 @@ def flush(self): | |||
|
|
|||
| def seek(self, offset, whence=os.SEEK_SET): | |||
| """Move internal pointer by *offset*.""" | |||
| self.wrapped_file.seek(offset, whence) | |||
| return self.wrapped_file.seek(offset, whence) | |||
There was a problem hiding this comment.
consider updating parent class doc string to indicate that position is returned.
source/ftrack_api/uploader.py
Outdated
| raise ValueError("Invalid file size.") | ||
|
|
||
|
|
||
| async def back_off(func: Callable[..., Awaitable], *args, retries=5, delay=5): |
There was a problem hiding this comment.
maybe include typing where possible ie
async def back_off(func: Callable[..., Awaitable], *args:typing.Any, retries:int=5, delay:int=5):
|
|
||
| startPos = (part_num - 1) * self.chunk_size | ||
| self.file.seek(startPos) | ||
| content = self.file.read(self.chunk_size) |
There was a problem hiding this comment.
we are reusing the same file object across all tasks, I suppose that is fine since we are reading / seeking synchronously?
There was a problem hiding this comment.
yeah, we are reading synchronously and are reading the content before dropping it to the upload task.
Resolves FT-2fc3d98e-2756-45f4-b39f-3ddbef956a2f
Changes
Using httpx as async HTTP library for upload request.
Test