Skip to content

feat: Improve strong-typing of Schema types #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 21, 2023
Merged

feat: Improve strong-typing of Schema types #86

merged 5 commits into from
Mar 21, 2023

Conversation

ffMathy
Copy link
Contributor

@ffMathy ffMathy commented Mar 17, 2023 •
edited
Loading

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

I am improving the typings of mappings as specified in https://help.ftrack.com/en/articles/1040505-schemas.

Test

Check that code still compiles, and tests run. This has already been done.

@ffMathy ffMathy changed the title Update types.ts Improve strong-typing of Schema types Mar 21, 2023
@ffMathy ffMathy marked this pull request as ready for review March 21, 2023 09:25
@ffMathy ffMathy requested a review from a team as a code owner March 21, 2023 09:25
@gismya gismya self-assigned this Mar 21, 2023
gismya
gismya suggested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@gismya gismya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
Looks great, just a few minor details to adjust.

ffMathy and others added 2 commits March 21, 2023 12:59
@ffMathy @gismya
Update source/types.ts
8b63501 
Co-authored-by: Lars Johansson <[email protected]>
@ffMathy @gismya
Update source/types.ts
8d34aad 
Co-authored-by: Lars Johansson <[email protected]>
@ffMathy
Copy link
Contributor Author

ffMathy commented Mar 21, 2023

@gismya thanks a bunch for your feedback! I applied the suggested corrections now.

gismya
gismya approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@gismya gismya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great initiative!

@ffMathy
Copy link
Contributor Author

ffMathy commented Mar 21, 2023

@gismya great to hear - what are the next steps? How does your release process work? Is there anything else I need to do to get this out? 😃

@gismya
Copy link
Contributor

gismya commented Mar 21, 2023

I'm having a colleague do a second round, and if I didn't miss anything obvious he'll merge it. Then we'll trigger a release, which should all be done before the end of the day.

@gismya gismya changed the title Improve strong-typing of Schema types feat: Improve strong-typing of Schema types Mar 21, 2023
@jimmycallin
Copy link
Contributor

The PR check is failing due to forks not having access to environment secrets (which is reasonable), so we can ignore that.

@ffMathy
Copy link
Contributor Author

ffMathy commented Mar 21, 2023

The PR check is failing due to forks not having access to environment secrets (which is reasonable), so we can ignore that.

I think GitHub made it so that if you explicitly retry a build, it will include the secrets (depending on Repo settings though).

jimmycallin
jimmycallin approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@jimmycallin jimmycallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks for your contribution! i'll merge this and make a new release :)

@jimmycallin jimmycallin merged commit d435bfb into ftrackhq:main Mar 21, 2023
gismya added a commit to gismya/ftrack-javascript that referenced this pull request Apr 11, 2023
@ffMathy @gismya
feat: Improve strong-typing of Schema types (ftrackhq#86)
ab44ccc 
* Update types.ts

* Fix for typing of API.

* Update source/types.ts

Co-authored-by: Lars Johansson <[email protected]>

* Update source/types.ts

Co-authored-by: Lars Johansson <[email protected]>

---------

Co-authored-by: Lars Johansson <[email protected]>
gismya added a commit that referenced this pull request May 15, 2023
@ffMathy @gismya
feat: Improve strong-typing of Schema types (#86)
d62e21f 
* Update types.ts

* Fix for typing of API.

* Update source/types.ts

Co-authored-by: Lars Johansson <[email protected]>

* Update source/types.ts

Co-authored-by: Lars Johansson <[email protected]>

---------

Co-authored-by: Lars Johansson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmycallin jimmycallin jimmycallin approved these changes

@gismya gismya gismya approved these changes

Assignees

@gismya gismya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffMathy @gismya @jimmycallin