fix: Re-add previously removed non-standard functionality of passing blobs with name properties #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lobs with name properties
gismya
approved these changes
Feb 21, 2023
gismya
pushed a commit
that referenced
this pull request
May 15, 2023
…blobs with name properties (#80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
During typescript migration we removed possibility to pass Blob instances with name properties. This is non-standard, and the recommended fix is to pass
options.nameinstead. But re-adding this functionality since we have instances that rely on this.Test
Make sure you can add Blobs with name properties.
Test it by installing dependency:
yarn up @ftrack/api@https://github.com/ftrackhq/ftrack-javascript.git#fix/blob-name.