Skip to content

fix: window.addEventListener breaks node compatibility #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: window.addEventListener breaks node compatibility #148

merged 2 commits into from
Sep 15, 2023

Conversation

gismya
Copy link
Contributor

@gismya gismya commented Sep 15, 2023

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

My last minute addition of an online event handler to make reconnects faster was not node compatible since it uses window.addEventListener. This PR adds a conditional to only add the event-listener if it's actually possible.

Test

@gismya gismya requested a review from a team as a code owner September 15, 2023 11:28
@gismya gismya linked an issue Sep 15, 2023 that may be closed by this pull request
Issue after 1.8.0: window is not defined #147
Closed
@gismya gismya merged commit ace305d into main Sep 15, 2023
@gismya gismya deleted the 147-issue-after-180-window-is-not-defined branch September 15, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmycallin jimmycallin jimmycallin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue after 1.8.0: window is not defined
2 participants
@gismya @jimmycallin