Type URI now requires protocol scheme. #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorbaptista
requested review from
vitorbaptista
and removed request for
akariv and
roll
vitorbaptista
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes URI type consistent in
JS&PYversions oftableschema.Here https://github.com/frictionlessdata/tableschema-py/blob/7de2c803bbb0ee034c2f376be26466c8b956ae48/tableschema/types/string.py#L48 tableschema-py requires protocol to be presented in URI type, same will be required in JS version from now.
Infer()method will treat value8.8.8.8as a String with type DefaultValidator changed its behavior accordingly.
Fix issues:
#135
frictionlessdata/tableschema-py#204
datahubio/datahub-v2-pm#126
datahubio/datahub#121