Skip to content

Fixes multiarch docker build #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

Fixes multiarch docker build #3550

merged 1 commit into from
Oct 26, 2022

Conversation

konstantinzolotarev
Copy link
Contributor

Resolves docker build for multiarch arm64 and amd64

Motivation

Related to #3545 and #3513

Solution

Configure CFLAGS dependent on image arch.

Note:
ARG TARGETARCH is provided by docker itself on build stage.

mattsse
mattsse approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, ty!

@mattsse mattsse merged commit 6dcc162 into foundry-rs:master Oct 26, 2022
@mattsse mattsse added the T-bug Type: bug label Oct 26, 2022
@konstantinzolotarev konstantinzolotarev deleted the fix-multiarch-docker branch October 26, 2022 11:24
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
@konstantinzolotarev @iFrostizz
Fixes multiarch docker build (foundry-rs#3550)
65d7172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstantinzolotarev @mattsse