fix(docker):add cflag to avoid build errors #3514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Oct 19, 2022
| @@ -1,17 +1,19 @@ | |||
| FROM alpine AS build-environment | |||
| FROM alpine as build-environment | |||
| ENV CFLAGS=-mno-outline-atomics | |||
|
Wdym?
…On Wed, 19 Oct 2022 at 15:16, Matthias Seitz ***@***.***> wrote:
***@***.**** commented on this pull request.
ty.
ref rust-lang/rust#81808 <rust-lang/rust#81808>
------------------------------
In Dockerfile
<#3514 (comment)>:
> @@ -1,17 +1,19 @@
-FROM alpine AS build-environment
+FROM alpine as build-environment
+ENV CFLAGS=-mno-outline-atomics
can we make this aarch64 only?
—
Reply to this email directly, view it on GitHub
<#3514 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH773DQPDI6BLXZ2ESKEBBTWD7KB5ANCNFSM6AAAAAARI6RAUA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
this seems to be only a problem on aarch64 platforms, so I think we should only set this only for aarch64 |
|
bumping this up as I dont understand why we should check for |
|
I see, should be fine. |
2 tasks
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
Co-authored-by: Genysys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This closes #3513
Solution