Skip to content

fix: Fetch pages before findBy #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020
Merged

fix: Fetch pages before findBy #5876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/routes/pages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import classic from 'ember-classic-decorator';
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';

@classic
export default class PagesRoute extends Route {

@service cache;

// Enumerate possible page names for extraction for localization
pages() {
return [this.l10n.t('Terms'), this.l10n.t('Contact'), this.l10n.t('Refund Policy'), this.l10n.t('Privacy')];
Expand All @@ -12,8 +16,8 @@ export default class PagesRoute extends Route {
return this.l10n.tVar(model?.name) || this.l10n.t('Pages');
}

model(params) {
return this.modelFor('application').pages.findBy('url', params.path);
async model(params) {
return (await this.cache.query('pages', 'page', { public: true })).toArray().findBy('url', params.path);
}

renderTemplate(model) {
Expand Down