Skip to content

chore: Change general-date helper timezone argument #5799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2020
Merged

chore: Change general-date helper timezone argument #5799

merged 3 commits into from
Nov 28, 2020

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 27, 2020

Fixes #5795

Changes proposed in this pull request:

  • change the timezone to keyword argument, like {{general-date date tz=timezone}}

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/au9q8quza
✅ Preview: https://open-event-frontend-git-helper-argument-5795.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #5799 (84c4aa9) into development (d427ea6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5799   +/-   ##
============================================
  Coverage        23.48%   23.48%           
============================================
  Files              511      511           
  Lines             5454     5454           
  Branches            63       63           
============================================
  Hits              1281     1281           
  Misses            4157     4157           
  Partials            16       16           
Impacted Files Coverage Δ
app/helpers/general-date.js 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d427ea6...84c4aa9. Read the comment docs.

@divyamtayal
Copy link
Member Author

@iamareebjamal Its Done

@iamareebjamal iamareebjamal changed the title Change general-date helper timezone argument chore: Change general-date helper timezone argument Nov 28, 2020
@auto-label auto-label bot added the chore label Nov 28, 2020
@iamareebjamal iamareebjamal merged commit 2315c39 into fossasia:development Nov 28, 2020
@divyamtayal divyamtayal deleted the helper-argument-5795 branch November 28, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change general-date helper timezone argument
2 participants