Skip to content

fix: time error fix in wizard step 5 #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2020
Merged

fix: time error fix in wizard step 5 #5275

merged 1 commit into from
Oct 9, 2020

Conversation

maze-runnar
Copy link
Contributor

on changing time it was showing error like wizard step 1 previously.
Screenshot from 2020-10-09 17-48-20
on updating -
captured (1)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/d1jtxjafg
✅ Preview: https://open-event-frontend-git-another.eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Oct 9, 2020

@mariobehling It fixes #5271 also for me and I am not getting that error anymore. Can you please make sure?

@maze-runnar maze-runnar changed the title fix: time error fix in wizard fix: time error fix in wizard step 5 Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #5275 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5275      +/-   ##
===============================================
+ Coverage        22.86%   22.92%   +0.05%     
===============================================
  Files              491      491              
  Lines             5226     5226              
  Branches            36       36              
===============================================
+ Hits              1195     1198       +3     
+ Misses            4026     4023       -3     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630602c...00c77d7. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 97c20e2 into fossasia:development Oct 9, 2020
@maze-runnar maze-runnar deleted the another branch October 9, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants