Skip to content

chore: Configure sentry release and trace sample rate #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iamareebjamal
Copy link
Member

No description provided.

@auto-label auto-label bot added the chore label Oct 8, 2020
@vercel
Copy link

vercel bot commented Oct 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/qrgt91oqe
✅ Preview: https://open-event-fronten-git-f33331a53d22590c626a9e71b33ea56a1-b1e778.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 2
           

Complexity increasing per file
==============================
- app/sentry.ts  5
- config/environment.js  1
         

See the complete overview on Codacy

@@ -58,7 +58,8 @@ module.exports = function(environment) {
dsn : process.env.SENTRY_DSN || 'https://[email protected]/dummy',
debug : !!process.env.SENTRY_DSN,
development : !process.env.SENTRY_DSN,
tracesSampleRate: process.env.SENTRY_TRACE_SAMPLE_RATE || 0.01,
release : (process.env.SENTRY_PROJECT_NAME || 'eventyay-frontend') + '@' + process.env.npm_package_version,
tracesSampleRate: process.env.SENTRY_TRACE_SAMPLE_RATE || 0.1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -58,7 +58,8 @@ module.exports = function(environment) {
dsn : process.env.SENTRY_DSN || 'https://[email protected]/dummy',
debug : !!process.env.SENTRY_DSN,
development : !process.env.SENTRY_DSN,
tracesSampleRate: process.env.SENTRY_TRACE_SAMPLE_RATE || 0.01,
release : (process.env.SENTRY_PROJECT_NAME || 'eventyay-frontend') + '@' + process.env.npm_package_version,
tracesSampleRate: process.env.SENTRY_TRACE_SAMPLE_RATE || 0.1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Unexpected trailing comma.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #5265 into development will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5265      +/-   ##
===============================================
+ Coverage        22.82%   22.88%   +0.05%     
===============================================
  Files              491      491              
  Lines             5226     5226              
  Branches            36       36              
===============================================
+ Hits              1193     1196       +3     
+ Misses            4028     4025       -3     
  Partials             5        5              
Impacted Files Coverage Δ
app/sentry.ts 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59628f9...f33331a. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 5d2d999 into fossasia:development Oct 8, 2020
@iamareebjamal iamareebjamal deleted the sentry-release-tracing branch October 8, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants