This repository was archived by the owner on Feb 25, 2025. It is now read-only.
a11y: Add SemanticsAction "showOnScreen" #3856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen. iOS implementation to follow.
jason-simmons
approved these changes
Jul 10, 2017
Hixie
reviewed
Jul 11, 2017
| @@ -77,7 +78,7 @@ public AccessibilityNodeInfo createAccessibilityNodeInfo(int virtualViewId) { | |||
|
|
|||
| AccessibilityNodeInfo result = AccessibilityNodeInfo.obtain(mOwner, virtualViewId); | |||
| result.setPackageName(mOwner.getContext().getPackageName()); | |||
| result.setClassName("Flutter"); // Prettier than the more conventional node.getClass().getName() | |||
| result.setClassName("Flutter"); // TODO(goderbauer): Set proper class names | |||
There was a problem hiding this comment.
Android TalkBack uses the class to determine how to behave (for an example see below where I set the class to ScrollView to get the correct scroll behavoir). And if you set the class to button for example, Android talkback will correctly announce that it is a button. There are more classes with special meaning, apparently.
|
Does this mean you found the magic way that lists get scrolled? |
Hixie
reviewed
Jul 11, 2017
| @@ -117,6 +118,9 @@ public AccessibilityNodeInfo createAccessibilityNodeInfo(int virtualViewId) { | |||
| result.addAction(AccessibilityNodeInfo.ACTION_SCROLL_FORWARD); | |||
| result.addAction(AccessibilityNodeInfo.ACTION_SCROLL_BACKWARD); | |||
| result.setScrollable(true); | |||
| // This tells Android's a11y to send scroll events when reaching the end of | |||
| // the visible viewport of a scrollable. | |||
| result.setClassName("android.widget.ScrollView"); | |||
There was a problem hiding this comment.
Oh, I see. The magic is to fake which class you are?
There was a problem hiding this comment.
Yes. That's exactly it.
goderbauer
added a commit
to goderbauer/flutter
that referenced
this pull request
Jul 19, 2017
This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen. This requires engine rolled to flutter/engine#3856. I am in the process of adding tests, but I'd like to get early feedback to see if this approach is OK.
goderbauer
added a commit
to flutter/flutter
that referenced
this pull request
Jul 19, 2017
* a11y: implement new SemanticsAction "showOnScreen" (v2) This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen. This requires engine rolled to flutter/engine#3856. I am in the process of adding tests, but I'd like to get early feedback to see if this approach is OK. * fix null check * review comments * review comments * Add test * fix analyzer warning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen.
iOS implementation to follow.
Addresses flutter/flutter#1714 for Android.