fix: skip running flutter doctor on windows if no_rich_output=True

[ndonkoHenri]

Description

Error message

  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Scripts\flet.exe\__main__.py", line 7, in <module>
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\flet\cli\cli.py", line 88, in main
    args.handler(args)
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\flet\cli\commands\build.py", line 360, in handle
    with console.status(
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\status.py", line 106, in __exit__
    self.stop()
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\status.py", line 91, in stop
    self._live.stop()
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\live.py", line 147, in stop
    with self.console:
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\console.py", line 864, in __exit__
    self._exit_buffer()
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\console.py", line 822, in _exit_buffer
    self._check_buffer()
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\console.py", line 2024, in _check_buffer
    self._write_buffer()
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\console.py", line 2060, in _write_buffer
    legacy_windows_render(buffer, LegacyWindowsTerm(self.file))
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\_windows_renderer.py", line 17, in legacy_windows_render
    term.write_styled(text, style)
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\_win32_console.py", line 442, in write_styled
    self.write_text(text)
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\site-packages\rich\_win32_console.py", line 403, in write_text
    self.write(text)
  File "C:\hostedtoolcache\windows\Python\3.12.2\x64\Lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeEncodeError: 'charmap' codec can't encode character '\u221a' in position 0: character maps to <undefined>

\u221a' represents the square root character, which comes from flutter doctor.

Summary by Sourcery

Fix a bug by skipping the execution of flutter doctor on Windows when no_rich_output=True to avoid Unicode encoding errors. Improve code readability by refactoring the handling of platform and output settings.

Bug Fixes:

• Skip running flutter doctor on Windows if no_rich_output=True to prevent Unicode encoding errors.

Enhancements:

• Refactor code to use self.no_rich_output and self.current_platform for better readability and maintainability.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses an issue with running flutter doctor on Windows when no_rich_output=True. The main changes involve skipping the flutter doctor command in this specific scenario and refactoring some code for better organization and readability.

Sequence diagram for handling flutter doctor execution

sequenceDiagram
    actor User
    participant CLI as Command Line Interface
    participant BuildCmd as Build Command
    participant Flutter as Flutter

    User->>CLI: Run build command
    CLI->>BuildCmd: Initialize build
    BuildCmd->>BuildCmd: Check no_rich_output and platform
    alt no_rich_output is True and platform is Windows
        BuildCmd->>BuildCmd: Skip flutter doctor
    else
        BuildCmd->>Flutter: Run flutter doctor
    end
    BuildCmd->>CLI: Complete build process
    CLI->>User: Return build result

Loading

File-Level Changes

Change	Details	Files
Skip running flutter doctor on Windows when no_rich_output is True	Add a condition to check if no_rich_output is True and the platform is Windows Wrap the run_flutter_doctor call in an if statement to skip it when the condition is met	sdk/python/packages/flet/src/flet/cli/commands/build.py
Refactor code for better organization and readability	Move import statements to improve organization Introduce self.no_rich_output and self.current_platform as class attributes Replace local variables with class attributes for consistency	sdk/python/packages/flet/src/flet/cli/commands/build.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ndonkoHenri - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a brief comment explaining why flutter doctor needs to be skipped on Windows when no_rich_output is True. This will help future maintainers understand the rationale behind this platform-specific behavior.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[FeodorFitsner]

Fix a conflict here please.