ElevatedButton, FilledButton and FilledTonalButton issue on disable

[andrerotband]

Description

The code works if I leave the default button:

import flet as ft

def main(page: ft.Page):
    def change_bt2(e):
        bt2.disabled = not bt2.disabled
        bt2.text = "Disabled" if bt2.disabled else "Enabled"
        page.update()

    bt1 = ft.ElevatedButton(text="Disable / Enable", on_click=change_bt2, width=200)
    bt2 = ft.ElevatedButton(
        height=40,
        width=150,
        text="Enabled",
    )
    page.add(bt1, bt2)

if __name__ == "__main__":
    ft.app(target=main)

But if I change the color or background color of the button it has problems.
It does not change the color of the button to appear disabled

import flet as ft

def main(page: ft.Page):
    def change_bt2(e):
        bt2.disabled = not bt2.disabled
        bt2.text = "Disabled" if bt2.disabled else "Enabled"
        page.update()

    bt1 = ft.ElevatedButton(text="Disable / Enable", on_click=change_bt2, width=200)
    bt2 = ft.ElevatedButton(
        bgcolor=ft.colors.INDIGO,
        height=40,
        width=150,
        text="Enabled",
    )
    page.add(bt1, bt2)

if __name__ == "__main__":
    ft.app(target=main)

Flet version (pip show flet):

Name: flet
Version: 0.9.0
Summary: Flet for Python - easily build interactive multi-platform apps in Python
Home-page:
Author: Appveyor Systems Inc.
Author-email: [email protected]
License: Apache-2.0
Location: c:\src\flet\copahospeda\.venv\Lib\site-packages
Requires: copier, flet-runtime, packaging, pydantic, qrcode, watchdog, websocket-client, websockets
Required-by:

Operating system:

Windows 10

[andrerotband]

I checked the ElevatedButton code and fixed the issue:

flet_core: elevated_button.py

   def _before_build_command(self):
        super()._before_build_command()
        if self.__color is not None or self.__bgcolor is not None or self.__elevation is not None:
            if self.__style is None:
                self.__style = ButtonStyle()
            if self.__style.color != self.__color and not self.disabled:
                self.__style.color = self.__color
            if self.__style.bgcolor != self.__bgcolor and not self.disabled:
                self.__style.bgcolor = self.__bgcolor
            if self.__style.elevation != self.__elevation:
                self.__style.elevation = self.__elevation
        if self.__style is not None:
            self.__style.side = self._wrap_attr_dict(self.__style.side)
            self.__style.shape = self._wrap_attr_dict(self.__style.shape)
        self._set_attr_json("style", self.__style)

I changed to:

    def _before_build_command(self):
        super()._before_build_command()
        if self.__color is not None or self.__bgcolor is not None or self.__elevation is not None:
            if self.__style is None:
                self.__style = ButtonStyle()
            self.__style.color = self.__color if not self.disabled else None
            self.__style.bgcolor = self.__bgcolor if not self.disabled else None
            if self.__style.elevation != self.__elevation:
                self.__style.elevation = self.__elevation
        if self.__style is not None:
            self.__style.side = self._wrap_attr_dict(self.__style.side)
            self.__style.shape = self._wrap_attr_dict(self.__style.shape)
        self._set_attr_json("style", self.__style)

And it's working properly!

I hope I have contributed!

[ndonkoHenri]

Related issue: #1503 ?

[andrerotband]

The problem is different. In #1503 the person is disabling the column and wants the buttons inside the column to be disabled as well.

[andrerotband]

Hi!
What do you think about of my fix for this bug?
I would like to contribute to the Flet project.

[andrerotband]

Dear @FeodorFitsner :

Did you see my fix here?

[FeodorFitsner]

@andrerotband Yes, thank you. I've modified it a little bit though: 684bf1f